Markers (TODO / FIXME)

data/SugarBean.php4

Type Line Description
todo 181 This should be replaced by altering the current user before the call to save.
fixme 3818 Bug? we should remove the magic number -99
todo 5270 this function needs adjustment
todo 1330 Add support for field type validation and encoding of parameters.

soap/SoapRelationshipHelper.php1

Type Line Description
fixme 213 This is not a DB-safe code. Does not work on SQL Server & Oracle.

service/v4/SugarWebServiceUtilv4.php1

Type Line Description
todo 628 handle role

service/v4/SugarWebServiceImplv4.php1

Type Line Description
todo 772 permissions?

modules/Products/SubPanelView.php1

Type Line Description
todo 92 will this ever get called? accounts detailview does not have a select button for products subpanel

modules/ModuleBuilder/views/view.labels.php1

Type Line Description
todo 53 Bundle Studio and ModuleBuilder label handling to increase maintainability.

modules/ModuleBuilder/views/view.tree.php1

Type Line Description
todo 51 Bundle Studio and ModuleBuilder label handling to increase maintainability.

modules/ModuleBuilder/controller.php1

Type Line Description
todo 563 FOR MB

modules/ModuleBuilder/MB/MBModule.php1

Type Line Description
todo 852 replace by similar mechanism to StudioModule to determine the list of available views for this module

modules/ModuleBuilder/parsers/views/UndeployedSubpanelImplementation.php1

Type Line Description
todo 58 history

modules/ModuleBuilder/parsers/views/SubpanelMetaDataParser.php1

Type Line Description
todo 55 check the implementations

modules/ModuleBuilder/parsers/relationships/AbstractRelationships.php1

Type Line Description
todo 171 error handling in case we get a badly formed definition and hence relationship

modules/OptimisticLock/LockResolve.php1

Type Line Description
fixme 40 Replace the comparison here with a function from SugarWidgets

modules/SchedulersJobs/SchedulersJob.php4

Type Line Description
todo 146 figure out what error is thrown when no more apache instances can be spun off
todo 169 make the below configurable
todo 246 what we do if job fails, notify somebody?
todo 255 what we do if job fails, notify somebody?

modules/Reports/Report.php4

Type Line Description
fixme 837 needs DB-independent code here
fixme 1716 see if we need to handle NULLs on GROUP BY
fixme 1744 this needs to be fixed.. turn on summary sorting
todo 2179 wp this should be done in the widget

modules/Reports/schedule/ReportSchedule.php1

Type Line Description
todo 49 This code should never be used

modules/Import/sources/ImportFile.php1

Type Line Description
todo 251 Add auto detection for field delim and qualifier properteis.

modules/Users/views/view.edit.php1

Type Line Description
fixme 154 Translate error prefix

modules/DynamicFields/DynamicField.php1

Type Line Description
todo 487 fix this - saveToVardefs() updates GLOBAL['dictionary'] correctly, obtaining its information directly from the fields_meta_data table via buildCache()...

modules/Teams/TeamSet.php1

Type Line Description
todo 99 CONCAT

modules/Teams/Popup_picker.php1

Type Line Description
todo 137 cleanup the construction of $addform

modules/Teams/TeamSetManager.php1

Type Line Description
todo 400 we can remove the team_set_id from the WHERE if we don't care about reassignment

modules/Schedulers/SchedulerDaemon.php2

Type Line Description
todo 442 figure if this is better than the above check
todo 518 make sure this will fail gracefully

modules/WorkFlowActionShells/Popup_picker.php1

Type Line Description
todo 72 GET ALL ALERTS HERE

modules/Meetings/Meeting.php1

Type Line Description
todo 851 do we really need focus, name and view params for this function

modules/History/metadata/subpaneldefs.php1

Type Line Description
todo 43 try and merge with the activities

modules/SNIP/iCalParser.php1

Type Line Description
todo 300 try to find right timezone?

modules/Notes/Note.php1

Type Line Description
todo 225 Seems odd we need to clear out these values so that list views don't show the previous rows value if current value is blank

modules/Activities/metadata/subpaneldefs.php2

Type Line Description
todo 46 remove name=nothing and make it safe
todo 47 update layout editor to match new file structure

modules/Campaigns/QueueCampaign.php1

Type Line Description
todo 153 SM: may want to move this to query clause above instead

modules/SugarFeed/Dashlets/SugarFeedDashlet/SugarFeedDashlet.php1

Type Line Description
fixme 286 Actually calculate the oldest sugar feed we can see, once we get an API that supports this sort of filter.

modules/WorkFlowAlertShells/Popup_picker.php1

Type Line Description
todo 72 GET ALL ALERTS HERE

modules/Currencies/Currency.php1

Type Line Description
todo 475 refactor this. unit tests should not have static dependencies

modules/Calendar/CalendarUtils.php2

Type Line Description
todo 179 CHECK DATETIME VARIABLE
todo 360 CHECK DATETIME VARIABLE

modules/Configurator/metadata/SugarpdfSettingsdefs.php1

Type Line Description
todo 255 translate

modules/Leads/views/view.convertlead.php1

Type Line Description
todo 245 This should probably be on the smarty template

modules/Leads/ConvertLayoutMetadataParser.php1

Type Line Description
todo 178 Add history support to the convert leads layout editor.

modules/Contacts/Popup_picker.php1

Type Line Description
todo 85 cleanup the construction of $addform

modules/Administration/controller.php1

Type Line Description
todo 69 find way to enforce order

modules/vCals/HTTP_WebDAV_Server_vCal.php4

Type Line Description
todo 105 throw if not a directory
todo 278 support this if ext/zlib filters are available
todo 298 we have to ensure that implementations support this or send 501 instead
todo 304 maybe we can just pretend here?

modules/Groups/EditView.php1

Type Line Description
todo 45 figure out why i have to hard-code this data load?

modules/Emails/Email.php2

Type Line Description
todo 1155 make this update?
todo 3127 Consider moving to SugarBean to allow other models to set fields to NULL

modules/InboundEmail/InboundEmail.php3

Type Line Description
todo 4491 add team security to this query
todo 4681 figure out if the since date is UDT
todo 5297 - set team_id, team_set for new UI

install/install_utils.php1

Type Line Description
fixme 1835 where should it be?

portal/index.php1

Type Line Description
todo 370 move this code into $theme/header.php so that we can be within the and tags.

portal/include/utils.php2

Type Line Description
todo 417 Update to use global cache
todo 1218 Clint 5/20 - Make this function more generic so that it can take in the target form and field names as variables

include/SugarDateTime.php3

Type Line Description
todo 144 better way to not risk locale stuff problems?
fixme 568 locale?
fixme 577 locale?

include/ListView/ListViewSmarty.php1

Type Line Description
todo 215 Cleanup, better logic for which modules are exempt from the new messaging.

include/ListView/ListView.php1

Type Line Description
todo 282 expensive and needs to be removed and done better elsewhere

include/ListView/ListViewXTPL.php1

Type Line Description
todo 134 make popups / listview check saving the same

include/SugarOAuthServer.php1

Type Line Description
fixme 89 add ts/nonce verification

include/Expressions/Expression/Numeric/DivideExpression.php1

Type Line Description
todo 40 add caching of return values

include/Expressions/Expression/Numeric/SubtractExpression.php1

Type Line Description
todo 40 add caching of return values

include/Expressions/Expression/Numeric/AverageExpression.php1

Type Line Description
todo 40 add caching of return values

include/Expressions/Expression/Numeric/MultiplyExpression.php1

Type Line Description
todo 40 add caching of return values

include/Expressions/Expression/Numeric/AddExpression.php1

Type Line Description
todo 40 add caching of return values

include/Expressions/Expression/String/ContainsExpression.php1

Type Line Description
todo 41 add caching of return values

include/Expressions/Expression/String/ConcatenateExpression.php1

Type Line Description
todo 41 add caching of return values

include/Expressions/metadata/metatojs.php1

Type Line Description
todo 29 remove aliasing

include/MySugar/MySugar.php1

Type Line Description
todo 609 the css is not fully inherited in this file

include/MassUpdate.php2

Type Line Description
todo 205 define filter array here to optimize the query
todo 527 allow ACL access for Delete to be set false always for users

include/workflow/field_utils.php1

Type Line Description
fixme 800 Special cases for known non-db but allowed fields

include/SugarQueue/SugarJobQueue.php3

Type Line Description
todo 163 soft-delete old done jobs?
todo 186 tranaction start?
todo 210 commit/check?

include/Popups/PopupSmarty.php1

Type Line Description
todo 534 cleanup the construction of $addform

include/Popups/Popup_picker.php1

Type Line Description
todo 125 cleanup the construction of $addform

include/upload_file.php2

Type Line Description
fixme 403 Translate
fixme 415 Translate

include/externalAPI/LotusLive/ExtAPILotusLive.php3

Type Line Description
todo 284 Implement this, get the meeting information from the provided tags.
fixme 406 Translate
fixme 485 Translate

include/externalAPI/GoToMeeting/ExtAPIGoToMeeting.php4

Type Line Description
fixme 127 Use TimeDate
fixme 204 Use TimeDate
fixme 273 Translate
fixme 284 Translate

include/externalAPI/cmis_repository_wrapper.php15

Type Line Description
todo 120 Make this work with cookies
todo 215 Make this storage optional
todo 304 Review
todo 386 Maybe use ->length=0 to even detect null values
todo 402 RRM FIX THIS
todo 464 RRM FIX THIS
todo 693 Fix Type Caching with missing properties
todo 760 Refactor Type Entries Caching
todo 778 Refactor Type Entries Caching
todo 782 Need GenURLQueryString Utility
todo 784 Need right URL
todo 840 Need GenURLQueryString Utility
todo 850 Need GenURLQueryString Utility
todo 860 Need GenURLQueryString Utility
todo 1112 Need Proper Query String Handling

include/externalAPI/Google/ExtAPIGoogle.php2

Type Line Description
fixme 119 bail if auth token not set
fixme 217 can't we just use the httpClient? It should add auth automatically

include/externalAPI/WebEx/ExtAPIWebEx.php4

Type Line Description
fixme 127 Use TimeDate
todo 131 what's openTime?
fixme 323 Translate
fixme 336 Translate

include/externalAPI/Facebook/ExtAPIFacebook.php3

Type Line Description
fixme 57 Translate
fixme 81 Translate
fixme 116 Translate

include/externalAPI/Base/ExternalAPIBase.php1

Type Line Description
fixme 62 check if the bean is validated, if not, refuse it?

include/externalAPI/Base/OAuthPluginBase.php2

Type Line Description
fixme 180 error checking here
fixme 192 error checking here

include/Dashlets/DashletRssFeedTitle.php1

Type Line Description
todo 60 use curl with waiting timeout instead of fopen

include/TimeDate.php5

Type Line Description
fixme 1094 if the string is short, should we assume date or time?
todo 1164 should we return clone?
todo 307 add caching
todo 337 add caching
todo 1901 There is hardcoded HTML in here that does not allow for localization of the AM/PM am/pm Strings in this drop down menu. Also, perhaps change to the substr_count function calls to strpos TODO: Remove after full switch to fields

include/Sugarpdf/Sugarpdf.php2

Type Line Description
todo 416 ISSUE - width in % for the td have to be multiply by the number of column.
todo 622 explode with space is not the best things to do...

include/generic/SugarWidgets/SugarWidgetSubPanelTopCreateTaskButton.php1

Type Line Description
todo 96 move this out and get $additionalFormFields working properly

include/generic/SugarWidgets/SugarWidgetSubPanelTopButtonQuickCreate.php1

Type Line Description
todo 106 move this out and get $additionalFormFields working properly

include/generic/SugarWidgets/SugarWidgetSubPanelTopScheduleMeetingButton.php1

Type Line Description
todo 96 move this out and get $additionalFormFields working properly

include/generic/SugarWidgets/SugarWidgetSubPanelTopButton.php2

Type Line Description
todo 44 rename defines to layout defs and make it a member variable instead of passing it multiple layers with extra copying.
todo 182 move this out and get $additionalFormFields working properly

include/generic/SugarWidgets/SugarWidgetSubPanelRelFieldEditButton.php1

Type Line Description
todo 34 Rename this to edit link

include/generic/SugarWidgets/SugarWidgetSubPanelTopScheduleCallButton.php1

Type Line Description
todo 96 move this out and get $additionalFormFields working properly

include/generic/SugarWidgets/SugarWidgetSubPanelEditButton.php1

Type Line Description
todo 34 Rename this to edit link

include/generic/SugarWidgets/SugarWidgetSubPanelTopCreateNoteButton.php1

Type Line Description
todo 96 move this out and get $additionalFormFields working properly

include/generic/SugarWidgets/SugarWidget.php1

Type Line Description
todo 31 move me out of generic

include/generic/SugarWidgets/SugarWidgetFielddatetimecombo.php1

Type Line Description
todo 41 now for date time field , we just search from date start to date end. The time is from 00:00:00 to 23:59:59

include/generic/SugarWidgets/SugarWidgetSubPanelCloseButton.php1

Type Line Description
todo 34 Rename this to close button field

include/clean.php1

Type Line Description
todo 108 remove this later!

include/SubPanel/SubPanel.php1

Type Line Description
todo 157 what about unions?

include/SubPanel/registered_layout_defs.php1

Type Line Description
todo 40 add global memory cache support here. If there is an in memory cache, leverage it.

include/controller/Controller.php2

Type Line Description
todo 254 jgreen - this is only single axis check_wall mechanism, will need to upgrade this to double axis
todo 312 jgreen - Add dual axis motion

include/HTMLPurifier/HTMLPurifier.standalone.php36

Type Line Description
fixme 611 ^^ not always, see start and value of list items
todo 12659 create custom child-definition for noscript that
todo 12665 convert this to new syntax, main problem is getting
todo 60 We need an easier way to inject strategies using the configuration object.
todo 1251 Refactor duplicate elements into common class (probably using composition, not inheritance).
todo 1341 Reconsider some of the public member variables
todo 2216 Unit test
todo 2455 Create a separate maintenance file advanced users can use to cache their custom HTMLDefinition, which can be loaded via a configuration directive
todo 2455 Implement memcached
todo 3953 Refactor interface so that configuration/context is determined upon instantiation, no need for messy generateFromTokens() calls
todo 3953 Make some of the more internal functions protected, and have unit tests work around that
todo 4185 This really ought to be protected, but until we have a facility for properly generating HTML here w/o using tokens, it stays public.
todo 4588 Give this its own class, probably static interface
todo 4634 Consider making some member functions protected
todo 5337 Allow injectors to request a re-run on their output. This would help if an operation is recursive.
todo 5611 Make it private, fix usage in HTMLPurifier_LanguageTest
todo 5683 Implement conditionals? Right now, some messages make reference to line numbers, but those aren't always available
todo 5741 Serialized cache for languages
todo 6311 Consider making protected
todo 6363 Consider making protected
todo 6875 Port DirectLex to use this
todo 8065 Make protected
todo 8847 Make protected
todo 9488 Make protected
todo 9494 Make protected
todo 11653 Make protected
todo 11663 Make protected
todo 11673 Make protected
todo 12881 Figure out how to protect some of these methods/properties
todo 12910 Wildcard matching and error reporting when an added or subtracted fix has no effect.
todo 13366 Ensure all states are unit tested, including variations as well.
todo 13366 Make a graph of the flow control for this Injector.
todo 14281 Reread XML spec and document differences.
todo 14817 Enable nodes to be bubbled out of the structure.
todo 16639 Validate the email address
todo 16639 Filter allowed query parameters

include/HTMLPurifier/standalone/HTMLPurifier/Filter/ExtractStyleBlocks.php1

Type Line Description
todo 36 Extend to indicate non-text/css style blocks

include/HTMLPurifier/standalone/HTMLPurifier/Lexer/PEARSax3.php1

Type Line Description
todo 3 Generalize so that XML_HTMLSax is also supported.

include/HTMLPurifier/standalone/HTMLPurifier/Printer/ConfigForm.php1

Type Line Description
todo 3 Rewrite to use Interchange objects

include/HTMLPurifier/standalone/HTMLPurifier/Printer/HTMLDefinition.php1

Type Line Description
todo 231 Also add information about internal state

include/utils.php3

Type Line Description
todo 711 Update to use global cache
todo 1747 Clint 5/20 - Make this function more generic so that it can take in the target form and field names as variables
todo 4298 this won't work completely right until we impliment css compression and combination for now, we'll just include the last css file found.

include/database/MssqlManager.php2

Type Line Description
fixme 586 this looks really bad. Probably source for tons of bug
fixme 2009 go back to the original DB

include/database/IBMDB2Manager.php3

Type Line Description
todo 343 add logic to make this generated when there is a sequence being used
todo 566 take this skip out when the DB2 bug is fixed
todo 1534 Should we implement an OS verification if a user exists???

include/database/DBManager.php2

Type Line Description
todo 717 : refactor engine param to be more generic
todo 803 : refactor engine param to be more generic

include/SugarSearchEngine/Elastic/Elastica/Client.php2

Type Line Description
todo 220 similar to delete ids but with type and index inside files
todo 281 Test

include/SugarSearchEngine/Elastic/Elastica/Filter/Ids.php2

Type Line Description
todo 44 Shouldn't this throw an exception?
todo 60 Shouldn't this throw an exception or let handling of invalid params to ES?

include/SugarSearchEngine/Elastic/Elastica/Filter/GeoDistance.php1

Type Line Description
todo 39 validate distance?

include/SugarSearchEngine/Elastic/Elastica/Filter/Script.php1

Type Line Description
todo 36 check if should be renamed to setScript?

include/SugarSearchEngine/Elastic/Elastica/Transport/Abstract.php1

Type Line Description
todo 12 set default method?

include/SugarSearchEngine/Elastic/Elastica/Transport/Http.php1

Type Line Description
todo 58 REFACTOR

include/SugarSearchEngine/Elastic/Elastica/Type/Abstract.php2

Type Line Description
todo 2 Add some settings examples to code
todo 2 Add some settings examples to code

include/SugarSearchEngine/Elastic/Elastica/Query.php1

Type Line Description
todo 54 Implement queries without

include/SugarSearchEngine/Elastic/Elastica/Index/Status.php2

Type Line Description
todo 63 Update as soon as new API is implmented
todo 75 Update as soon as new API is implmented

include/SugarSearchEngine/Elastic/Elastica/Index.php3

Type Line Description
todo 110 doesn't seem to work?
todo 282 add additional cache clean arguments
todo 294 Add option for refresh

include/SugarSearchEngine/Elastic/Elastica/Type.php2

Type Line Description
todo 231 To be implemented, can also be implemented on index and client level (see docs)
todo 245 Not tested yet

include/SugarSearchEngine/Elastic/SugarSearchEngineElastic.php2

Type Line Description
todo 501 Determine why term filters aren't working with the hyphen present.
fixme 755 convert to use autoloader

include/phpmailer/class.phpmailer.php3

Type Line Description
todo 1408 check this worked
todo 1916 using /e (equivalent to eval()) is probably not a good idea
todo 2346 Should this not be using __set() magic function?

include/SugarFields/Fields/Collection/ViewSugarFieldCollection.php2

Type Line Description
todo 255 Change to an other view
todo 475 the 'select' button is not fully working. We should use the sqs_objects in open_popup instead of the parameter.

include/MVC/View/views/view.gs.php1

Type Line Description
todo 150 Handle enums since we are destroying the key.

include/connectors/utils/ConnectorUtils.php1

Type Line Description
todo 84 if we don't know this connector, should we decide it's enabled or disabled?

include/utils/layout_utils.php2

Type Line Description
todo 296 refactor this into the base Popup_Picker class
todo 342 refactor this into the base Popup_Picker class

include/utils/db_utils.php1

Type Line Description
todo 65 Make this utilize the external caching mechanism after re-testing (see log on r25320). Bug 49489 - removed caching of to_html strings as it was consuming memory and never releasing it

include/utils/LogicHook.php1

Type Line Description
todo 221 Make a factory for these classes. Cache instances accross uses

include/SugarCache/SugarCache.php1

Type Line Description
todo 92 make it so developers can extend this somehow